The min-nights modifiers should get cleared according to the previous prop value not the new one #994
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
force-pushed
the
maja-clear-min-nights-on-demand
branch
from
2781b68 to
2277896
Compare
ljharb
reviewed
Feb 2, 2018
|
👍 on a little more detail and test(s). |
majapw
force-pushed
the
maja-clear-min-nights-on-demand
branch
from
2277896 to
729675b
Compare
… prop value not the new one
majapw
force-pushed
the
maja-clear-min-nights-on-demand
branch
from
729675b to
7b6b04b
Compare
|
I added some regression tests! Please take a look @ljharb |
ljharb
approved these changes
May 7, 2018
| const startDate = today; | ||
| const focusedInput = START_DATE; | ||
| const minimumNights = 5; | ||
| const wrapper = shallow(<DayPickerRangeController |
There was a problem hiding this comment.
fwiw, the linter will soon require:
const wrapper = shallow((
<DayPickerRangeController
startDate={startDate}
focusedInput={focusedInput}
minimumNights={minimumNights}
/>
));There was a problem hiding this comment.
we'll have to do a wholesale change of... most tests at that point. 😬
ljharb
added
the
semver-patch: fixes/refactors/etc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition, we don't seem to be removing the
blockedmodifier from these days at all. Whoops!Here is a gif of the bug in action (not this only happens when you change the min nights value from a bigger value to a smaller value).
Now we will remove min nights blocking according to the previous value and also, any time the value changes (and reapply it for new >0 values).
to: @amhunt @ljharb @erin-doyle