Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix background-color theming for Calendar and DateInput #852

Merged
merged 2 commits into from
Nov 27, 2017

Conversation

Rickkorsten
Copy link

Hi, first of all great library, thanks for the great work! 👍👍

We're using a dark theme with react-dates and noticed some backgrounds were not themable or hardcoded to white. This pull request fixes that, so you can correctly theme the background color.

Before (the calendar navigation borders are not affected by this PR):
image
image

After:
image
image

Love to see this merged.

regards,
Rick & Hein

@coveralls
Copy link

Coverage Status

Coverage remained the same at 86.553% when pulling 8256b3e on Rickkorsten:feature-full-theme-support into 96655cf on airbnb:master.

Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable to me! Thanks!

@majapw majapw merged commit bd5f52a into react-dates:master Nov 27, 2017
@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Nov 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants