DayPickerSingleDateController support phrases. Changed phrases state … #623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljharb
previously requested changes
Jul 14, 2017
| @@ -543,9 +543,10 @@ export default class DayPickerSingleDateController extends React.Component { | |||
| renderCalendarInfo, | |||
| isFocused, | |||
| isRTL, | |||
| phrases | |||
There was a problem hiding this comment.
This line needs a trailing comma
majapw
approved these changes
Jul 19, 2017
|
@davidskoog can you add a regression test for this? That's all I'm waiting on :-) |
ljharb
dismissed
their stale review
Per discussion; let's bring this in now but ASAP ensure we're testing all the phrases props.
|
Hi again @ljharb. Sorry for this late reply. I'm have been on vacation for a time. I see that you merged my pull request, exciting. I don't know what a regression test is but until next time I will find out. // David |
|
@davidskoog just an automated test to prevent this specific issue from occurring in the future - i.e., from "regressing". |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DayPickerSingleDateController support phrases. Changed phrases state to props.
When using DayPickerSingleDateController I'm not able to use phrases for language translations.
Here is a suggestion for a solution.