Fix for initialVisibleMonth in DayPickerRangeController (#613) #617
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aleib
changed the title
aleib
changed the title
majapw
requested changes
Jul 6, 2017
| @@ -819,6 +820,8 @@ export default class DayPickerRangeController extends React.Component { | |||
| } = this.props; | |||
|
|
|||
| const { phrases, visibleDays } = this.state; | |||
| const initialVisibleMonthThunk = | |||
| initialVisibleMonth || (startDate ? () => startDate : () => moment()); | |||
There was a problem hiding this comment.
This looks great! This is definitely a bug (I originally didn't catch is because the wrapper I'm using has an initialVisibleMonth default prop).
…t of the DayPickerSingleDateController Also fix the examples wrappers
majapw
force-pushed
the
al-613-initial-visible-month
branch
from
6308746
to
82ffc8f
Compare
majapw
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original issue:
is initialVisibleMonth now required for DayPickerRangeController
Looking at the commit logs I think this commit broke the component when initialVisibleMonth is not set on DayPickerRangeController
By changing the default prop from:
initialVisibleMonth: DayPickerDefaultProps.initialVisibleMonthto
initialVisibleMonth: null,as it will pass
nulldown to the DayPicker component on renderSo made the prop a function as in DateRangePicker