Move constants to top level directory #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-major: breaking change
majapw
force-pushed
the
move-constants-to-top-level-directory
branch
4 times, most recently
from
7cf44f0
to
b64d0c2
Compare
|
LGTM - looks like you'll need to update some paths in tests too |
|
Oops! I totally thought I had. |
majapw
force-pushed
the
move-constants-to-top-level-directory
branch
2 times, most recently
from
ae3dae3
to
bfeeef0
Compare
majapw
force-pushed
the
move-constants-to-top-level-directory
branch
from
bfeeef0
to
2609919
Compare
This should allow consumers to do `import { START_DATE, END_DATE } from 'react-dates/constants';` which is ideal
majapw
force-pushed
the
move-constants-to-top-level-directory
branch
from
2609919
to
0e45890
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to allow for
import { START_DATE END_DATE } from 'react-dates/constants';and it makes sense for it not to need transpilation since the file is literally a collection of strings. However, it is breaking.