Allows for a custom display format #52
Conversation
majapw
force-pushed
the
allow-for-custom-date-format
branch
from
ded16c8
to
9410154
Compare
|
Well dang! Haha, that's awesome, you rock @majapw. 👍 👍 |
| getDateString(date) { | ||
| const { displayFormat } = this.props; | ||
| if (displayFormat) { | ||
| return date && date.format(displayFormat); |
There was a problem hiding this comment.
when date is falsy, can you remind me what toLocalizedDateString will return?
There was a problem hiding this comment.
toLocalizedString returns null for falsey dates. I'm going to go back and add some tests for that I think.
There was a problem hiding this comment.
Ha! I already wrote a test - https://github.com/airbnb/react-dates/blob/master/test/utils/toLocalizedDateString_spec.js#L7:L9
There was a problem hiding this comment.
would it be better to do if (date && displayFormat) so that falsy dates always go through toLocalizedDateString? With the current approach, passing NaN with a format will return NaN, for example.
|
Hmm, I just realized that this still expects |
majapw
force-pushed
the
allow-for-custom-date-format
branch
2 times, most recently
from
da34fe2
to
92f8f50
Compare
majapw
force-pushed
the
allow-for-custom-date-format
branch
from
92f8f50
to
3e4f6c0
Compare
|
Hey @airbnb/webinfra can someone gimme a stamp on this? |
|
LGTM |
Fix for #26
@jcreamer898