Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add showDefaultInputIcon and customInputIcon for SingleDatePicker #513

Merged
merged 4 commits into from
May 17, 2017
Merged

Add showDefaultInputIcon and customInputIcon for SingleDatePicker #513

merged 4 commits into from
May 17, 2017

Conversation

b0gok
Copy link
Contributor

@b0gok b0gok commented May 15, 2017

According to issue #368

@coveralls
Copy link

coveralls commented May 15, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 86.537% when pulling cad332a on b0gok:single_date_picker into 543ccb5 on airbnb:master.

@majapw
Copy link
Collaborator

majapw commented May 16, 2017

Awesome. I will take a look at this tomorrow!

@JemarJones
Copy link
Contributor

This would be super useful for me to have right now. @majapw How goes the reviewal?

@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.537% when pulling ca4010e on b0gok:single_date_picker into 01bd04f on airbnb:master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 86.537% when pulling ca4010e on b0gok:single_date_picker into 01bd04f on airbnb:master.

@ljharb
Copy link
Member

ljharb commented May 17, 2017

@b0gok please rebase on the command line; the "update" button on github creates a merge commit.

majapw
majapw requested changes May 17, 2017
View reviewed changes
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update the README and SingleDatePickerShape as well?

src/components/SingleDatePicker.jsx
@@ -54,6 +54,8 @@ const defaultProps = {
readOnly: false,
screenReaderInputMessage: '',
showClearDate: false,
showDefaultInputIcon: false,
customInputIcon: null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to pass this through as well, no?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, you are right, my mistake 🙁

examples/SingleDatePickerWrapper.jsx Outdated
@@ -36,6 +36,9 @@ const defaultProps = {
required: false,
screenReaderInputMessage: '',
showClearDate: false,
showDefaultInputIcon: false,
customInputIcon: null,
customCloseIcon: null,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change isn't adding a customCloseIcon is it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removed it

stories/SingleDatePicker_input.js
showDefaultInputIcon
/>
))
.addWithInfo('with custom show calendar icon', () => (
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this work right now? We don't appear to be passing through the customInputIcon

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it should work properly

majapw
majapw reviewed May 17, 2017
View reviewed changes
Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't forget to add them to the SingleDatePickerShape file! :) I think that's the last thing.

@coveralls
Copy link

coveralls commented May 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 86.537% when pulling 9444f50 on b0gok:single_date_picker into 0b88bbc on airbnb:master.

@b0gok
Copy link
Contributor Author

b0gok commented May 17, 2017

Don't forget to add them to the SingleDatePickerShape file! :) I think that's the last thing.

Done (:

@coveralls
Copy link

coveralls commented May 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 86.537% when pulling be474ce on b0gok:single_date_picker into 0b88bbc on airbnb:master.

@coveralls
Copy link

coveralls commented May 17, 2017 •
edited
Loading

Coverage Status

Coverage increased (+0.01%) to 86.537% when pulling be474ce on b0gok:single_date_picker into 0b88bbc on airbnb:master.

@majapw majapw merged commit 0eb0d04 into react-dates:master May 17, 2017
@b0gok b0gok deleted the single_date_picker branch May 18, 2017 08:56
@JemarJones
Copy link
Contributor

I would be forever grateful if this release happened soon 🤞

@majapw
Copy link
Collaborator

majapw commented May 18, 2017

v12.1.0 has been released!

@lopezdp
Copy link

lopezdp commented Feb 7, 2020

Are there any examples for this use case documented?

@b0gok
Copy link
Contributor Author

b0gok commented Feb 7, 2020

Are there any examples for this use case documented?

@lopezdp Here and here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@majapw majapw majapw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@b0gok @coveralls @majapw @JemarJones @ljharb @lopezdp