Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added a readOnly prop to the SingleDatePicker #501

Merged
merged 2 commits into from
May 10, 2017
Merged

Added a readOnly prop to the SingleDatePicker #501

merged 2 commits into from
May 10, 2017

Conversation

erin-doyle
Copy link
Collaborator

This will allow the DateInput to be set as readOnly (addresses #496).

@ljharb ljharb added the semver-minor: new stuff Any feature or API addition. label May 9, 2017
@ljharb
Copy link
Member

ljharb commented May 9, 2017

This LGTM, but it needs a rebase (to remove the merge commit)

@erin-doyle
Copy link
Collaborator Author

Ok, I think I've done the rebase properly. Let me know if not.

@majapw
Copy link
Collaborator

majapw commented May 9, 2017

I think if we're going to add this to the SingleDatePicker, it makes sense to add it to the DateRangePicker too, no?

Also, I do think we'll be paying some attention to revamping the inputs in the near future so that will likely help work on the problems this prop is trying to solve.

@ljharb
Copy link
Member

ljharb commented May 9, 2017

@erin-doyle no, there's still merge commits in the PR. Assuming origin is your fork and source is this repo, git checkout readonly_prop_#496 && git fetch source && git rebase source/master && git push -f origin readonly_prop_#496 should do it assuming there's no conflicts.

@coveralls
Copy link

coveralls commented May 10, 2017

Coverage Status

Coverage remained the same at 86.83% when pulling c73eca3 on erin-doyle:readonly_prop_#496 into 768578e on airbnb:master.

@erin-doyle
Copy link
Collaborator Author

Ok, I've rebased (sorry about that, I am not too strong with the git-fu yet 😜 ) and added the prop to DateRangePicker.

@coveralls
Copy link

coveralls commented May 10, 2017

Coverage Status

Coverage remained the same at 86.83% when pulling e36396f on erin-doyle:readonly_prop_#496 into 768578e on airbnb:master.

Copy link
Collaborator

@majapw majapw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lol pass-through props. Looks great!

@majapw majapw merged commit f9054d7 into react-dates:master May 10, 2017
@erin-doyle
Copy link
Collaborator Author

Great, thanks! 😄

@erin-doyle erin-doyle deleted the readonly_prop_#496 branch May 10, 2017 17:35
@majapw
Copy link
Collaborator

majapw commented May 10, 2017

Woo I'll do a release shortly after I get this one other PR in :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-minor: new stuff Any feature or API addition.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants