Only update phrases object when the focusedInput actually changes.

[majapw]

Realized this when I was prototyping some perf changes... but basically the modifiers object is not the only one that is changing (unnecessarily) on every render.

to: @moonboots @ljharb @airbnb/webinfra

[ljharb]

Seems reasonable.

Test coverage? :-)

[majapw]

@ljharb I'm not entirely sure how to test this, especially given that it is in componentWillReceiveProps

[coveralls]

Coverage decreased (-0.8%) to 83.1% when pulling 99f9863 on maja-fix-phrases-calendarday-rerendering into 782b5f3 on master.

[ljharb]

@majapw wrapper.instance().componentWillReceiveProps, unless .setProps() works

[coveralls]

Coverage decreased (-0.8%) to 83.1% when pulling 99f9863 on maja-fix-phrases-calendarday-rerendering into 782b5f3 on master.

[majapw]

Added some tests! 🎉

[lencioni]

Did you mean to actually write a test here?

[majapw]

I did. I just forgot. :P

[lencioni]

You could use destructuring here if you like.

[coveralls]

Coverage increased (+0.05%) to 83.961% when pulling b40b5d6 on maja-fix-phrases-calendarday-rerendering into 782b5f3 on master.

[coveralls]

Coverage increased (+0.05%) to 83.961% when pulling 062db26 on maja-fix-phrases-calendarday-rerendering into 782b5f3 on master.

[lencioni]

Just curious, did you measure the performance impact of this change?

[majapw]

@lencioni this change on its own will not have any performance impact due to the fact that each CalendarDay will still be updated on every hover or mouse interaction because modifiers gets rebuilt in every render at the top-level. However, I have been working on rearchitecturing modifiers pretty much entirely in a separate change and the combination of the two will lead to a huge speed-up.