Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moves phrases out into one shared defaultPhrases file #351

Merged
merged 1 commit into from
Mar 6, 2017

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Mar 2, 2017

to: @ljharb @airbnb/webinfra

This is to split up some of the code in #301, which I admit, got away from me somewhat.

@majapw majapw requested a review from ljharb March 2, 2017 22:26
@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Mar 2, 2017
@@ -7,6 +7,7 @@ instrumentation:
"public/**",
"test/**",
"coverage/**",
"src/defaultPhrases.js"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

trailing comma?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also why does this need to be ignored, if it's exercised on every import?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fair. I was thinking that we would ignore because writing tests for the file itself seems v. silly

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's useful to ensure that it can be imported without an error :-)

@@ -145,13 +144,16 @@ export default class DateRangePickerInput extends React.Component {
})}
>
{(showDefaultInputIcon || customInputIcon !== null) &&
<span
<button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

was this change meant to be included in this PR?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I figured we'd do some of the small aria-labeling/add those phrases unrelated to keyboard nav here.

@@ -80,6 +91,7 @@ export default function DayPickerNavigation(props) {
}

<span
aria-label={phrases.jumpToNextMonth}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I figured we'd do some of the small aria-labeling/add those phrases unrelated to keyboard nav here.

@@ -72,6 +82,7 @@ export default function DayPickerNavigation(props) {
<div className={navClassNames}>
{!isVerticalScrollable &&
<span
aria-label={phrases.jumpToPrevMonth}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I figured we'd do some of the small aria-labeling/add those phrases unrelated to keyboard nav here.

@@ -122,13 +121,11 @@ export default class SingleDatePickerInput extends React.Component {
'SingleDatePickerInput__clear-date--hide': !displayValue,
'SingleDatePickerInput__clear-date--hover': isClearDateHovered,
})}
aria-label={phrases.clearDate}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. I figured we'd do some of the small aria-labeling/add those phrases unrelated to keyboard nav here.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.4%) to 87.203% when pulling e887e69 on maja-move-phrases-into-separate-file into 04d08d4 on master.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(it'd be nice to not ignore the defaultPhrases file tho)

@majapw majapw merged commit eda475b into master Mar 6, 2017
@majapw majapw deleted the maja-move-phrases-into-separate-file branch March 6, 2017 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants