Set input value to use ISO format by default #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
majapw
added
the
semver-major: breaking change
ljharb
reviewed
Dec 21, 2016
|
I just realized this won't actually work for custom display formats. |
majapw
force-pushed
the
maja-set-input-default-value-to-use-iso
branch
2 times, most recently
from
7db7252
to
54af822
Compare
|
@ljharb let's try again. Lol. This is messier, but also less broken. PTAL? |
ljharb
approved these changes
Jan 13, 2017
| focused, | ||
| showCaret, | ||
| onFocus, | ||
| disabled, | ||
| required, | ||
| } = this.props; | ||
|
|
||
| const value = dateValue || dateString; | ||
| const displayText = displayValue || inputValue || dateString || placeholder; |
There was a problem hiding this comment.
does this also need an || '' at the end?
yo dawg, i heard you like defaults
| @@ -23,7 +23,9 @@ const propTypes = { | |||
| onClearDates: PropTypes.func, | |||
|
|
|||
| startDate: PropTypes.string, | |||
| startDateValue: PropTypes.string, | |||
There was a problem hiding this comment.
these need defaultProps (the linter checks this now)
majapw
force-pushed
the
maja-set-input-default-value-to-use-iso
branch
from
54af822
to
7eb9654
Compare
This was referenced Jan 26, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't add a layer of abstraction to format the date client side, the input value will be submitted directly to the server. As a result, I think we should not be using the display format but rather a standardized ISO-8601 format.
to: @jeffsee55 @airbnb/webinfra