[breaking] [deps] Update react-with-styles and other deps #1761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noratarano
added
the
semver-major: breaking change
noratarano
commented
Aug 20, 2019
noratarano
commented
Aug 20, 2019
| const { whyDidYouUpdate } = require('why-did-you-update'); | ||
| whyDidYouUpdate(React); | ||
| const whyDidYouRender = require('@welldone-software/why-did-you-render'); | ||
| whyDidYouRender(React); |
There was a problem hiding this comment.
This fixes a bug where there were two version of React present.
There was a problem hiding this comment.
It's no longer necessary, but it will save people lots of debugging time if they want to use hooks in this repo.
noratarano
force-pushed
the
nora--update-react-with-styles
branch
from
08a3a1e to
dbaa3b7
Compare
ljharb
reviewed
Aug 21, 2019
noratarano
added
semver-patch: fixes/refactors/etc
noratarano
force-pushed
the
nora--update-react-with-styles
branch
from
dbaa3b7 to
00dc88e
Compare
|
@ljharb Is it a requirement to add tests if I didn't make any changes 🤔 |
noratarano
force-pushed
the
nora--update-react-with-styles
branch
3 times, most recently
from
1419bc3 to
fe79a98
Compare
ljharb
requested changes
Aug 23, 2019
noratarano
force-pushed
the
nora--update-react-with-styles
branch
2 times, most recently
from
38bd2b2 to
8c748cd
Compare
ljharb
changed the title
|
What’s the breaking change in v4 alpha 1 of r-w-s? |
noratarano
force-pushed
the
nora--update-react-with-styles
branch
from
8c748cd to
1dab51a
Compare
ljharb
approved these changes
Sep 4, 2019
noratarano
force-pushed
the
nora--update-react-with-styles
branch
from
1dab51a to
f671ffb
Compare
noratarano
added
semver-major: breaking change
noratarano
changed the title
|
@ljharb The breaking change in RWS@4 is drop support for node 6, and added @babel/runtime as a peer dep. |
noratarano
force-pushed
the
nora--update-react-with-styles
branch
from
c0b3c42 to
b6438b0
Compare
added 4 commits
September 9, 2019 16:44
- Drop support for node < 6 - Update: @storybook, webpack, react-with-styles, react-with-direction, react-with-styles-interface-aphrodite, react-with-styles-interface-css, react-with-styles-interface-css-compiler
This is required to use react-with-styles@4.0.0
noratarano
force-pushed
the
nora--update-react-with-styles
branch
2 times, most recently
from
86875b3 to
d4ea820
Compare
noratarano
force-pushed
the
nora--update-react-with-styles
branch
from
d4ea820 to
db4e194
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
react-with-stylesto latest version as well as a few other required deps.Breaking changes:
Testing
Ran both storybooks (regular and css) and ran tests
Reviewers
@lencioni @ljharb @ahuth @indiesquidge @majapw @goatslacker