Run SVGs through SVGO with most aggressive settings #1690
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that these SVGs could be optimized a little more, by reducing the precision. The end result is slightly different, but at the size they are used, I don't think it will really be perceptible. I left close.svg alone because it has a 12x12 viewBox instead of a 1000x1000 viewbox, so the precision here is actually pretty important for the shape. I think some more bytes could maybe be squeezed out of these by recreating them from hand using different shapes instead of paths, but that's a bit more work than I'd like to do at this time. This optimization reduces the size of the svg directory from 2678 bytes to 2106 bytes.
I found that I can squeeze out a few extra bytes in this SVG by running it through svgcleaner.
|
Can you share a visual diff? 500bytes is pretty tiny. |
|
@ljharb I've added some screenshots. |
ljharb
approved these changes
Jun 17, 2019
|
@ljharb probably not worth the effort. Also, svgo removes the focusable attribute which I had to manually add back in. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that these SVGs could be optimized a little more, by reducing
the precision. The end result is slightly different, but at the size
they are used, I don't think it will really be perceptible.
I left close.svg alone because it has a 12x12 viewBox instead of a
1000x1000 viewbox, so the precision here is actually pretty important
for the shape.
I think some more bytes could maybe be squeezed out of these by
recreating them from hand using different shapes instead of paths, but
that's a bit more work than I'd like to do at this time.
This optimization reduces the size of the svg directory from 2678 bytes
to 2106 bytes.
Screenshots before:
Screenshots after: