add hovered-start-blocked-minimun-nights and hovered-start-first-possible-end modifiers #1547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@TaeKimJR @noratarano @monokrome Can you also please take a look? Thanks! |
ljharb
approved these changes
Feb 19, 2019
nkinser
force-pushed
the
nk--add-modifier-for-styles-depending-on-hovered-day
branch
2 times, most recently
from
7fb6fb3 to
49c6582
Compare
ljharb
reviewed
Feb 27, 2019
| it('does not call addModifierToRange with `hovered-start-blocked-minimum-nights` if the hovered date is blocked', () => { | ||
| const addModifierToRangeSpy = sinon.spy(DayPickerRangeController.prototype, 'addModifierToRange'); | ||
| const getMinNightsForHoverDateStub = sinon.stub().returns(2); | ||
| const wrapper = shallow(<DayPickerRangeController |
ljharb
reviewed
Feb 27, 2019
| {...props} | ||
| getMinNightsForHoverDate={getMinNightsForHoverDateStub} | ||
| isDayBlocked={day => isSameDay(day, today)} | ||
| />); |
ljharb
reviewed
Feb 27, 2019
| @@ -0,0 +1 @@ | |||
| {"value":{"success":true,"data":{"next":{"version":"5.0.0-rc.6","info":{"plain":"### Bug Fixes\n\n* Addon-actions: FIX performance by upgrading to telejson 2.1 ([#5751](https://github.com/storybooks/storybook/pull/5751))\n* UI: FIX bad treeview mockdata ([#5741](https://github.com/storybooks/storybook/pull/5741))\n* UI: About page styling fixes ([#5732](https://github.com/storybooks/storybook/pull/5732))\n* UI: Restore the toolbar eject button ([#5737](https://github.com/storybooks/storybook/pull/5737))"}},"latest":{"version":"4.1.13","info":{"plain":"### Documentation\n\n* Fix unkind addon-ondevice-knobs readme. ([#5629](https://github.com/storybooks/storybook/pull/5629))\n\n### Maintenance\n\n* Cleanup CLI version notice ([#5699](https://github.com/storybooks/storybook/pull/5699))\n* Use static versions.json file instead of hacking one in ([#5675](https://github.com/storybooks/storybook/pull/5675))"}}},"time":1551291194564},"type":"Object"} | |||
nkinser
force-pushed
the
nk--add-modifier-for-styles-depending-on-hovered-day
branch
from
53dd10f to
3a5bfe6
Compare
…rst-possible-end modifiers
…en it is a touch device
nkinser
force-pushed
the
nk--add-modifier-for-styles-depending-on-hovered-day
branch
from
3a5bfe6 to
99135fe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds two new modifiers,
hovered-start-blocked-minimum-nightsandhovered-start-first-possible-end, which, whenfocusedInputisSTART_DATE, keep track of the days blocked by the minimum nights requirement and the first possible end date for the hovered day. This makes the user aware of the minimum nights requirement before even clicking on the day.I added the
getMinNightsForHoverDatefunction to the props because in my case it is possible for the min nights requirement for the hovered date to be different from the one passed in as theminimumNightsprop.I originally intended to make a more generic modifier similar to
highlighted-calendarwhere the user could supply the function used to determine if the day should have the modifier applied to it, but it was too computationally heavy to call this function on every visible day every time the hover day changed.Gif of change:
Reviewers:
@majapw @ljharb