Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes the focus out event in IE11 #1524

Merged
merged 13 commits into from
Feb 7, 2019
Merged

Fixes the focus out event in IE11 #1524

merged 13 commits into from
Feb 7, 2019

Conversation

marcos0x
Copy link
Contributor

@marcos0x marcos0x commented Feb 1, 2019

No description provided.

@marcos0x marcos0x mentioned this pull request Feb 1, 2019
Closed
@coveralls
Copy link

coveralls commented Feb 1, 2019 •
edited
Loading

Coverage Status

Coverage decreased (-0.5%) to 84.504% when pulling afcd575 on marcos0x:fix/focus-out-event-ie11 into 7083d2a on airbnb:master.

@majapw majapw requested a review from monokrome February 4, 2019 02:02
@majapw
Copy link
Collaborator

majapw commented Feb 4, 2019

Can we add context to the comment about this check?

@ljharb
Copy link
Member

ljharb commented Feb 4, 2019

also surfacing #1524 (comment)

monokrome
monokrome suggested changes Feb 4, 2019
View reviewed changes
Copy link
Contributor

@monokrome monokrome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small request for changes, but looks good :) Thanks for contributing back to the project!

src/components/DateRangePicker.jsx Outdated Show resolved Hide resolved
@monokrome
Copy link
Contributor

@marcos0x Would you mind adding tests for this usecase?

@marcos0x
Copy link
Contributor Author

marcos0x commented Feb 6, 2019

@monokrome It is tested in IE11 and works well

ljharb
ljharb approved these changes Feb 6, 2019
View reviewed changes
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great.

src/components/DateRangePicker.jsx Outdated Show resolved Hide resolved
src/components/DateRangePicker.jsx Show resolved Hide resolved
@marcos0x
Copy link
Contributor Author

marcos0x commented Feb 7, 2019

@monokrome Can you approve this?

@ljharb ljharb added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Feb 7, 2019
@devans-k4
Copy link

Waiting on this as well. Thanks btw @marcos0x

@majapw majapw merged commit a7a7c46 into react-dates:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@monokrome monokrome monokrome approved these changes

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@marcos0x @coveralls @majapw @ljharb @monokrome @devans-k4 @m-avila