Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Conditionally apply the shouldComponentUpdate method #1457

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Conditionally apply the shouldComponentUpdate method #1457

merged 1 commit into from
Nov 8, 2018

Conversation

majapw
Copy link
Collaborator

@majapw majapw commented Nov 7, 2018 •
edited by ljharb
Loading

Fixes #1455

This updates the PureComponent fallback babel transform to conditionally apply shouldComponentUpdate only in cases where React.PureComponent is not supported (otherwise it throws an error).

to: @skevy @ljharb

@majapw majapw added the semver-patch: fixes/refactors/etc Anything that's not major or minor. label Nov 7, 2018
@coveralls
Copy link

coveralls commented Nov 7, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 85.049% when pulling 3413dcb on maja-patch-babel-transform into eafc6f1 on master.

@majapw
Copy link
Collaborator Author

majapw commented Nov 8, 2018

Verified that the console errors are gone!

@majapw majapw merged commit 8c45ed0 into master Nov 8, 2018
@majapw majapw deleted the maja-patch-babel-transform branch November 8, 2018 00:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ljharb ljharb ljharb approved these changes

Assignees
No one assigned
Labels
semver-patch: fixes/refactors/etc Anything that's not major or minor.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@majapw @coveralls @ljharb