[a11y] expose a callback for when the user hits tab or shift tab inside the day picker #1427
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the day picker For an upcoming refactor, we need to be able to listen for when the user hits tab inside the day picker. This is to support an a11y change in which the daypicker will become an immediate sibling of the date input so the user can just naturally tab into it. The problem is that when the user hits tab to exit the day picker, we need to close the calendar, which is currently done inside the DateRangePickerInputController.
ljharb
reviewed
Oct 22, 2018
majapw
approved these changes
Oct 22, 2018
|
Sorry @Sumeet-Jain! I'll do a release right now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For an upcoming refactor, we need to be able to listen for when the user
hits tab inside the day picker. This is to support an a11y change in
which the daypicker will become an immediate sibling of the date input
so the user can just naturally tab into it. The problem is that when the
user hits tab to exit the day picker, we need to close the calendar,
which is currently done inside the DateRangePickerInputController. The bigger
refactor will be done in another pr
Testing
Npm linked this change and then tested e2e refactor. Also added a spec
Reviewers
@majapw