Hides the TetherComponent appropriately #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FIx for #125
Ooops, while the
DateRangePicker__picker--showandDateRangePicker__picker--invisibledo the right thing, when they are wrapped in a top-level div without these restrictions, they actually prevent point-events on anything rendered beneath them. This is... pretty bad.This fixes the problem by applying the show/hide logic directly to the
TetherComponent. I also updated the tests and added a story to make sure you can interact with other form elements rendered beneath the datepicker.to: @airbnb/webinfra @ingro @zeroasterisk @tvanro