Bump RWS and RWS interfaces

[majapw]

I have tested this by running npm run build and npm run build:css and both seem to successfully generate the CSS file! :) This will allow us to not have this weird deps issue and get the latest and greatest of react-with-styles changes.

to: @ljharb @gabergg

[coveralls]

Coverage remained the same at 86.513% when pulling f953b03 on maja-bump-rws-and-rws-css into c22ccc2 on master.

[gabergg]

LGTM

[aminland]

This change caused our webpack builds to start failing with the following error (v16.3.0 was fine):

Module not found: Error: Recursion in resolving
Stack:
  resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten
  new-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten
  parsed-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten module
  described-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten module
  raw-module: (/Volumes/Documents/projects/fellow-core/web/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten
  module: (/Volumes/Documents/projects/fellow-core/web/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten
  resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules) ./array.prototype.flatten
  new-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules) ./array.prototype.flatten
  parsed-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules) ./array.prototype.flatten
  described-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules) ./array.prototype.flatten
  relative: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) 
  described-relative: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) 
  directory: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) 
  existing-directory: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) 
  resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) ./
  new-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) ./
  parsed-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) . directory
  described-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) . directory
  relative: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten)  directory
  described-relative: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten)  directory
  directory: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten)  directory
  existing-directory: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten)  directory
  resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) ./ directory
  new-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) ./ directory
  parsed-resolve: (/Volumes/Documents/projects/fellow-core/web/node_modules/array.prototype.flatten) . directory
 @ ./node_modules/react-with-styles-interface-css/dist/index.js 5:22-56
 @ ./node_modules/react-with-styles-interface-css/index.js
 @ ./node_modules/react-dates/lib/utils/registerCSSInterfaceWithDefaultTheme.js
 @ ./node_modules/react-dates/lib/initialize.js
 @ ./node_modules/react-dates/initialize.js
 @ ./src/components/App.js
 @ ./src/index.js
 @ multi (webpack)-dev-server/client?http://0.0.0.0 webpack/hot/only-dev-server react-hot-loader/patch babel-polyfill ./src/index.cjsx

All we're doing is an import at the top of our App.js component file import 'react-dates/initialize';

I'm pretty sure this is a significant backwards-incompatible change, and shouldn't have been released as a "patch".

[ianshea]

I'm having issues with this as well. I whipped a basic example.

https://github.com/ianshea/react-dates-broken-example

Adding array.prototype.flatten as a dependency with npm install --save array.prototype.flatten in the project does not alleviate this issue.

[majapw]

Huh that's really weird! I'll revert and investigate.

…

On Fri, Feb 23, 2018, 4:32 PM Ian Shea ***@***.***> wrote: I'm having issues with this as well. I whipped a basic example <https://github.com/ianshea/react-dates-broken-example>. https://github.com/ianshea/react-dates-broken-example Adding array.prototype.flatten as a dependency with npm install --save array.prototype.flatten in the project does not alleviate this issue. — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1041 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUdtQAEPetwkG2YqXjgvRB39Pc1rLPaks5tX1ibgaJpZM4SRY30> .

[majapw]

Hi @aminland @ianshea can you check to see if this is still an issue. I just released v16.3.2 with the revert. Sorry for the inconvenience. D:

[ianshea]

It's all good! I just did an update and reran my demo and I'm still seeing the issue though.

Specifically from the next command npm run dev I see the following:

 ERROR  Failed to compile with 1 errors                                                                                                                   18:45:55

This dependency was not found:

* array.prototype.flatten in ./node_modules/react-with-styles-interface-css/dist/index.js

To install it, you can run: npm install --save array.prototype.flatten

And here's a big ol' stack trace I'm seeing.

Error in ./dist/index.js
Module not found: Error: Recursion in resolving Stack: resolve: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten new-resolve: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten parsed-resolve: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten module described-resolve: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten module raw-module: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten module: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten resolve: (/Users/tester/node_modules) ./array.prototype.flatten new-resolve: (/Users/tester/node_modules) ./array.prototype.flatten parsed-resolve: (/Users/tester/node_modules) ./array.prototype.flatten described-resolve: (/Users/tester/node_modules) ./array.prototype.flatten relative: (/Users/tester/node_modules/array.prototype.flatten) described-relative: (/Users/tester/node_modules/array.prototype.flatten) directory: (/Users/tester/node_modules/array.prototype.flatten) existing-directory: (/Users/tester/node_modules/array.prototype.flatten) resolve: (/Users/tester/node_modules/array.prototype.flatten) ./ new-resolve: (/Users/tester/node_modules/array.prototype.flatten) ./ parsed-resolve: (/Users/tester/node_modules/array.prototype.flatten) . directory described-resolve: (/Users/tester/node_modules/array.prototype.flatten) . directory relative: (/Users/tester/node_modules/array.prototype.flatten) directory described-relative: (/Users/tester/node_modules/array.prototype.flatten) directory directory: (/Users/tester/node_modules/array.prototype.flatten) directory existing-directory: (/Users/tester/node_modules/array.prototype.flatten) directory resolve: (/Users/tester/node_modules/array.prototype.flatten) ./ directory new-resolve: (/Users/tester/node_modules/array.prototype.flatten) ./ directory parsed-resolve: (/Users/tester/node_modules/array.prototype.flatten) . directory

[majapw]

Hmmm, can you share the output of `npm ls`? Also, what happens if you blow up node_modules and run a fresh npm install? (Please do the npm ls first)

…

On Fri, Feb 23, 2018, 6:48 PM Ian Shea ***@***.***> wrote: It's all good! I just did an update and reran my demo and I'm still seeing the issue though. Specifically from the next command npm run dev I see the following: ERROR Failed to compile with 1 errors 18:45:55 This dependency was not found: * array.prototype.flatten in ./node_modules/react-with-styles-interface-css/dist/index.js To install it, you can run: npm install --save array.prototype.flatten And here's a big ol' stack trace I'm seeing. Error in ./dist/index.js Module not found: Error: Recursion in resolving Stack: resolve: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten new-resolve: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten parsed-resolve: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten module described-resolve: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten module raw-module: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten module: (/Users/tester/node_modules/react-with-styles-interface-css/dist) array.prototype.flatten resolve: (/Users/tester/node_modules) ./array.prototype.flatten new-resolve: (/Users/tester/node_modules) ./array.prototype.flatten parsed-resolve: (/Users/tester/node_modules) ./array.prototype.flatten described-resolve: (/Users/tester/node_modules) ./array.prototype.flatten relative: (/Users/tester/node_modules/array.prototype.flatten) described-relative: (/Users/tester/node_modules/array.prototype.flatten) directory: (/Users/tester/node_modules/array.prototype.flatten) existing-directory: (/Users/tester/node_modules/array.prototype.flatten) resolve: (/Users/tester/node_modules/array.prototype.flatten) ./ new-resolve: (/Users/tester/node_modules/array.prototype.flatten) ./ parsed-resolve: (/Users/tester/node_modules/array.prototype.flatten) . directory described-resolve: (/Users/tester/node_modules/array.prototype.flatten) . directory relative: (/Users/tester/node_modules/array.prototype.flatten) directory described-relative: (/Users/tester/node_modules/array.prototype.flatten) directory directory: (/Users/tester/node_modules/array.prototype.flatten) directory existing-directory: (/Users/tester/node_modules/array.prototype.flatten) directory resolve: (/Users/tester/node_modules/array.prototype.flatten) ./ directory new-resolve: (/Users/tester/node_modules/array.prototype.flatten) ./ directory parsed-resolve: (/Users/tester/node_modules/array.prototype.flatten) . directory — You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub <#1041 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/ABUdtb30L9GQn7vsRUgAtWpfUC7EsP9Jks5tX3iOgaJpZM4SRY30> .

[aminland]

I can confirm it is still broken, even after removing package-lock, node_modules, and fresh npm install.

manually switching installed "react-with-styles-interface-css" to "^3.0.0" fixes the problem for me locally.

[aminland]

This should be ^3.0.0 to resolve import error

[majapw]

So it's not actually this PR that is the issue. It's #1029

[majapw]

Okay v16.3.3 is out and should address this. I'm gonna investigate what the heck is going on.

[aminland]

So off of version 16.3.1, i could get it to work by changing the "main" entry in array.prototype.flatten/package.json to "index.js"

it is currently "./"

I haven't seen that anywhere before, not sure if it's a standard thing, or maybe it's my node version (8.9.2), but it seems to be the root cause. I believe you guys switched to using that shim from array_flatten in the react-with-styles-interface-css update.

[ljharb]

It’s definitely a standard thing; maybe it’s a webpack bug?

Could you share your webpack versions and config?

[aminland]

It's a webpack bug: webpack/enhanced-resolve#123