-
Notifications
You must be signed in to change notification settings - Fork 26.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Documentation for 'import/no-extraneous-dependencies' is missing #2727
Comments
Sure, that's fine. It's been a best practice in node for over a decade so I guess it just went without saying :-) |
I didn't find link related to this rule on eslint |
It's part of eslint-plugin-import. |
Link (this one?) |
Yep, that's the rule. I guess as a new section at the end of Modules? |
I have a PR up. Please take a look. |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as resolved.
This comment was marked as resolved.
hi @cseas i can solve this issue please assign me |
My .50 cents? Why is it something should be made a code style pattern if it can directly affect bundle sizes for ES modules? |
Everything can affect that, and that’s just not a rubric anyone should be applying to how your code is written. |
The rule is set to error in the config:
https://github.com/airbnb/javascript/blob/master/packages/eslint-config-airbnb-base/rules/imports.js#L71
But there's no mention of it in the guide:
https://github.com/airbnb/javascript/blob/master/README.md
This rule should be mentioned under the Modules section.
The text was updated successfully, but these errors were encountered: