Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update webpack.md to clarify what the config does #657

Closed
wants to merge 2 commits into from
Closed

Update webpack.md to clarify what the config does #657

wants to merge 2 commits into from

Conversation

wyuenho
Copy link

@wyuenho wyuenho commented Nov 4, 2016

Remove cheerio as it's no longer optional depending on React version. I've also added an alternative config using the IgnorePlugin that will achieve the same effect.

@wyuenho wyuenho mentioned this pull request Nov 4, 2016
…n. I've also added an alternative config using the IgnorePlugin that will achieve the same effect.

Update webpack.md
@ljharb ljharb added the docs label Nov 4, 2016
Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems 👍

@nfcampos
Copy link
Collaborator

Looks great @wyuenho would you mind rebasing on latest master?

@wyuenho wyuenho closed this Jan 19, 2017
@ljharb
Copy link
Member

ljharb commented Jan 20, 2017

@wyuenho any chance you'd be willing to reopen this and rebase it? I'd love to merge it.

@wyuenho
Copy link
Author

wyuenho commented Jan 20, 2017

Let me confirm with the people on #47 first. I see people are still using externals and I'm not sure why. It can probably be completely done away with.

@hpurmann
Copy link

I just had a problem with shallow when testing with Karma+Webpack (in mocha or when using mount, it's fine):

TypeError: (0 , _cheerio2.default) is not a function
    at ShallowTestWrapper.get (test/webpack-client-tests.js:69435:44)
    at ShallowTestWrapper.attr (test/webpack-client-tests.js:69351:19)
    at Assertion.<anonymous> (test/webpack-client-tests.js:56696:37)
    at Assertion.<anonymous> (test/webpack-client-tests.js:57115:20)
    at Assertion.ctx.(anonymous function) [as attr] (test/webpack-client-tests.js:11282:34)
    at Context.<anonymous> (test/webpack-client-tests.js:307560:32)

Using React 15.4.2 and enzyme 2.6.0.
The problem disappears when removing cheerio from externals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants