Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix an adapter table style in README.md #1734

Merged
merged 1 commit into from
Aug 8, 2018
Merged

Conversation

koba04
Copy link
Contributor

@koba04 koba04 commented Aug 8, 2018

No description provided.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This same table also lives in the migration guide.

README.md Outdated
@@ -43,7 +43,7 @@ React:
| `enzyme-adapter-react-16` | `^16.4.0-0` |
| `enzyme-adapter-react-16.3` | `~16.3.0-0` |
| `enzyme-adapter-react-16.2` | `~16.2` |
| `enzyme-adapter-react-16.1` | `~16.0.0-0 || ~16.1` |
| `enzyme-adapter-react-16.1` | `16.0.0-0 - 16.1.x` |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see how the pipes could cause a problem, but it’s essential to keep the same semver range here that the packages use. Can we find a way to make the pipes work?

@ljharb ljharb added the docs label Aug 8, 2018
@koba04
Copy link
Contributor Author

koba04 commented Aug 8, 2018

@ljharb I use \ to escape ||, which seems to work fine on GitHub.
The markdown preview of VSCode show \ though.

I've updated the table in the migration guide.

Copy link
Member

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@ljharb ljharb merged commit 2bc1f85 into enzymejs:master Aug 8, 2018
@koba04
Copy link
Contributor Author

koba04 commented Aug 8, 2018

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants