Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added mount/unmount APIs to ReactWrapper #155

Merged
merged 1 commit into from
Feb 2, 2016

Conversation

lelandrichardson
Copy link
Collaborator

These APIs only work if you are using a single document across tests, rather than using the describeWithDOM method which recycles the global document. This is because React caches a reference to the global document under the hood, which we can not do anything about unfortunately.

@lelandrichardson
Copy link
Collaborator Author

@ljharb or @goatslacker PTAL. I'm adding documentation right now. will update with that in a sec.

@lelandrichardson
Copy link
Collaborator Author

Also important to note: This PR changes our jsdom test strategy to load a single document for the entire test suite, which is the strategy we will be recommending moving forward (in enzyme 2.0 and onward)

@ljharb
Copy link
Member

ljharb commented Feb 2, 2016

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
semver: minor New stuff.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants