props not merged when shallow rendering in lifecycleExperimental #1088
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LarsHassler
changed the title
ljharb
requested changes
Aug 22, 2017
| @@ -262,7 +262,7 @@ class ShallowWrapper { | |||
| const state = instance.state; | |||
| const prevProps = instance.props || this[UNRENDERED].props; | |||
| const prevContext = instance.context || this[OPTIONS].context; | |||
| const nextProps = props || prevProps; | |||
| const nextProps = Object.assign({}, prevProps || {}, props || {}); | |||
There was a problem hiding this comment.
The fallback objects are not required here, and this should use object spread.
There was a problem hiding this comment.
Never tried without the fallback, good to know ;)
Updated the syntax
ljharb
approved these changes
Aug 23, 2017
LarsHassler
force-pushed
the
fix/props-not-merged-when-lifecycleExperimental
branch
from
a0a1096
to
d9e50bb
Compare
|
Commits are rebased now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When shallow rendering a component with
lifecycleExperimental: truethe lifecyle methodscomponentWillReceivePropsandshouldComponentUpdatewill only be called with the value given tosetProps, but not with old and new props merged.It works for shallow rendering without lifecycleExperimental.
Due to the "dirty hacks" i'm not sure if there is a better way to do this, but this at least fixes the dirty hacks.