Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix sunburst error. add less to package.json #205

Merged
merged 1 commit into from
Mar 29, 2016
Merged

Conversation

williaster
Copy link
Contributor

This fixes a JS bug that Lindsay + Dan Frank have been running into in sunbursts that they're eager to get in. See spinner here

Also on a fresh install less-loader says that it requires less as a peer dependecny, so I added it to package.json We should probably also figure out devDependencies vs dependencies in package.json in the future.

@landscape-bot
Copy link

Code Health
Code quality remained the same when pulling 1aee5b7 on airbnb:chris/sunburst-fix into 74c72b3 on airbnb:master.

@@ -293,7 +293,7 @@ function sunburstVis(slice) {
}
var currentNode = root;
for (var j = 0; j < levels.length; j++) {
var children = currentNode.children;
var children = currentNode.children || [];
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line 305 throws an error without this when children is undefined.

@williaster williaster merged commit 5561a49 into master Mar 29, 2016
@williaster williaster deleted the chris/sunburst-fix branch March 29, 2016 00:07
graceguo-supercat pushed a commit to graceguo-supercat/superset that referenced this pull request Oct 4, 2021
* feat: add function for parsing formatters from encoding

* fix: add unit test

* feat: add getter

* fix: update type
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
* feat: add function for parsing formatters from encoding

* fix: add unit test

* feat: add getter

* fix: update type
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 17, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
* feat: add function for parsing formatters from encoding

* fix: add unit test

* feat: add getter

* fix: update type
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 24, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
* feat: add function for parsing formatters from encoding

* fix: add unit test

* feat: add getter

* fix: update type
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 25, 2021
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
* feat: add function for parsing formatters from encoding

* fix: add unit test

* feat: add getter

* fix: update type
zhaoyongjie pushed a commit to zhaoyongjie/incubator-superset that referenced this pull request Nov 26, 2021
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5 labels Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 0.8.5
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants