Two hotfixes (#574)

* fix for dashboards created without slices * [hotfix] check_ownership param needed for adding slice to dashboard
apache · Jun 7, 2016 · 24a68f5 · 24a68f5
1 parent 0d800fa
commit 24a68f5
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/caravel/models.py b/caravel/models.py
@@ -315,7 +315,7 @@ def json_data(self):
             'dashboard_title': self.dashboard_title,
             'slug': self.slug,
             'slices': [slc.data for slc in self.slices],
-            'position_json': json.loads(self.position_json),
+            'position_json': json.loads(self.position_json) if self.position_json else [],
         }
         return json.dumps(d)
 

diff --git a/caravel/views.py b/caravel/views.py
@@ -508,7 +508,7 @@ def pre_add(self, obj):
             obj.slug = re.sub(r'\W+', '', obj.slug)
 
     def pre_update(self, obj):
-        check_ownership()
+        check_ownership(obj)
         self.pre_add(obj)