Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Project 1 Feedback from Team Zilean #75

Open
RushikeshPharate opened this issue Feb 10, 2022 · 4 comments
Open

Project 1 Feedback from Team Zilean #75

RushikeshPharate opened this issue Feb 10, 2022 · 4 comments

Comments

@RushikeshPharate
Copy link

RushikeshPharate commented Feb 10, 2022

System design is good and efficient. Also, dockerizing microservice is a commendable task and it works properly. Having user and session logic in one microservice is good but could have made 2 microservices out of it. Actually, both ways are correct but we went with the later one. Below are some observations from our side.

Pros:

  • UI looks great
  • Error validation works properly for every page

Cons:

  • UI doesn't have pagination.

Thanks
Team Zilean

@tanukansalgit
Copy link
Collaborator

tanukansalgit commented Feb 10, 2022

Thanks Team Zilean for the feedback,
The reason for choosing to maintain user data and session logic in same microservice is to save the effort of maintaining two microservices for the related data, as both modules will anyway remain independent during user session, and can communicate to one another without making network calls, when needed.

@aishwaryavijaysinhasane

I agree with Tanu but I think the professor suggested that we should develop user and session microservice differently because that is a scalable design because if in the future you have millions of users then it will distribute load properly

  1. Excellent work and architecture design is good.
  2. Frontend is not stable. It is displaying an error page that is poorly designed.
  3. Doker's effort is commendable.
  4. I think you could have developed asynchronous communication as now your system cannot handle multiple requests efficiently.

@adityarudrawar
Copy link
Collaborator

  1. I think you could have developed asynchronous communication as now your system cannot handle multiple requests efficiently.

We kept this in mind and tested RabbitMQ for asynchronous communication between API Gateway and Plotting Service since those are the most heavy lifters, but due to lack of our knowledge in it we were not able to pursue it. Either way its a good point from a point of scalability, which we'll definitely try to achieve the next time.

I agree with the scalable thing, but multiple network calls can simultaneously make the system very slow and both the data are very inter-related. Professor mentioned we can have two micro services as to show internal communication among them but we are fulfilling the same purpose among gateway and other services.

@ParnalPatil
Copy link
Contributor

Thanks for your feedback Rushikesh and Aishwarya!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants