Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separation of JDK from users home directory #217

Closed
qoire opened this issue Nov 23, 2018 · 4 comments
Closed

Separation of JDK from users home directory #217

qoire opened this issue Nov 23, 2018 · 4 comments
Assignees
Labels
bug Something isn't working high

Comments

@qoire
Copy link
Contributor

qoire commented Nov 23, 2018

As noted for the UAT session we were running: On windows, only the user that installed the application is able to run it successfully, even though it was installed into Program Files indicating the intent that it is a system application.

This is because we extract the Java Runtime into the $HOME (or windows equivalent) of the user running the installer.

This also leads to the situation where because the installer requires administrative rights, non-admin users cannot run the application after installation.

@qoire qoire added bug Something isn't working high labels Nov 23, 2018
@qoire
Copy link
Contributor Author

qoire commented Nov 23, 2018

Going to attempt a solution:

  • Package the jlinkd JRE in as part of the application folder. This way we can be sure that whoever is access has R/W access.

I suspect a similar approach should be used for Mac, where the JRE is self contained within the AionWallet.app folder.

@qoire
Copy link
Contributor Author

qoire commented Nov 23, 2018

Update:
53f48ab

Now bundles the jlinked JRE directly with into the program file application folder. This resolves this issue. There will be a follow-up on this to make the installation process easier.

@qoire qoire self-assigned this Nov 23, 2018
@qoire
Copy link
Contributor Author

qoire commented Nov 23, 2018

@centrys-otniel @centrys-cristian-ilca We need to equivalent for Mac and Linux, the JRE should always be self-contained within the installed application. For Linux it should be contained within the aion_ui folder itself. For Mac it should be contained within the AionWallet.app package.

@qoire
Copy link
Contributor Author

qoire commented Nov 23, 2018

#221

@qoire qoire closed this as completed Nov 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working high
Projects
None yet
Development

No branches or pull requests

1 participant