Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review Time Assertions in Tests: test_router_dataset_generic_fields #309

Open
jsmatias opened this issue May 8, 2024 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@jsmatias
Copy link
Member

jsmatias commented May 8, 2024

Description:
The current time assertion in the test_router_dataset_generic_fields, specifically the time set as 0.2, was increased due to intermittent failures observed during pre-commit locally. While the adjustment temporarily mitigated the failures, it's uncertain the purpose of initially setting the time to 0.1.

To ensure consistency in time-related assertions across tests, it is necessary to review and standardise the time assertions.

Proposed Solution:
The proposed solution involves the following steps:

  1. Review the purpose and significance of the time assertion set initially to 0.1.
  2. Standardise time assertions across tests to ensure consistency.

Originally from discussion in #298 (comment)

@jsmatias jsmatias changed the title Review and Standardize Time Assertions in Tests Review Time Assertions in Tests May 8, 2024
@jsmatias jsmatias changed the title Review Time Assertions in Tests Review Time Assertions in Tests: test_router_dataset_generic_fields May 8, 2024
@jsmatias jsmatias added the enhancement New feature or request label May 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant