Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new code-generator (Butcher) #1069

Merged
merged 10 commits into from
Nov 20, 2022
Merged

Adding new code-generator (Butcher) #1069

merged 10 commits into from
Nov 20, 2022

Conversation

JrooTJunior
Copy link
Member

@JrooTJunior JrooTJunior commented Nov 19, 2022

Description

Added integration with new code-generator named Butcher: https://github.com/aiogram/butcher

Type of change

  • Documentation (typos, code examples or any documentation update)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have added tests that prove my fix is effective or that my feature works as expected
  • New and existing unit tests pass locally with my changes
  • My changes generate no new warnings or errors
  • My changes are compatible with minimum requirements of the project
  • I have made corresponding changes to the documentation

@JrooTJunior JrooTJunior added new feature Missing feature docs Something is missing in docs api Issues or new features of Bot API ported Ported feature or fix 3.x Issue or PR for stable 3.x version code style Changes in code style typing Issues related to the type hints and static typing labels Nov 19, 2022
@JrooTJunior JrooTJunior added this to the 3.0.0-beta.7 milestone Nov 19, 2022
@JrooTJunior JrooTJunior self-assigned this Nov 19, 2022
@github-actions
Copy link

github-actions bot commented Nov 19, 2022

✔️ Changelog found.

Thank you for adding a description of the changes

@codecov
Copy link

codecov bot commented Nov 19, 2022

Codecov Report

Merging #1069 (6183e7b) into dev-3.x (c7779ab) will decrease coverage by 1.05%.
The diff coverage is 20.35%.

❗ Current head 6183e7b differs from pull request most recent head 9557db4. Consider uploading reports for the commit 9557db4 to get more accurate results

Impacted file tree graph

@@             Coverage Diff             @@
##           dev-3.x    #1069      +/-   ##
===========================================
- Coverage   100.00%   98.94%   -1.06%     
===========================================
  Files          313      319       +6     
  Lines         8398     8491      +93     
===========================================
+ Hits          8398     8401       +3     
- Misses           0       90      +90     
Flag Coverage Δ
unittests 98.94% <20.35%> (-1.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
aiogram/enums/__init__.py 0.00% <0.00%> (ø)
aiogram/enums/chat_type.py 0.00% <0.00%> (ø)
aiogram/enums/content_type.py 0.00% <0.00%> (ø)
aiogram/enums/dice_emoji.py 0.00% <0.00%> (ø)
aiogram/enums/topic_icon_color.py 0.00% <0.00%> (ø)
aiogram/enums/update_type.py 0.00% <0.00%> (ø)
aiogram/types/reply_keyboard_markup.py 100.00% <ø> (ø)
aiogram/client/session/aiohttp.py 98.98% <50.00%> (-1.02%) ⬇️
aiogram/client/session/base.py 98.86% <66.66%> (-1.14%) ⬇️
aiogram/methods/create_forum_topic.py 100.00% <100.00%> (ø)
... and 9 more

@aiogram aiogram deleted a comment from github-actions bot Nov 19, 2022
@JrooTJunior JrooTJunior changed the title Re-generate all entities Adding new code-generator (Butcher) Nov 20, 2022
@JrooTJunior JrooTJunior marked this pull request as ready for review November 20, 2022 22:45
@JrooTJunior JrooTJunior merged commit d034c1b into dev-3.x Nov 20, 2022
@evgfilim1 evgfilim1 self-requested a review November 21, 2022 08:01
@evgfilim1 evgfilim1 mentioned this pull request Nov 26, 2022
@JrooTJunior JrooTJunior deleted the codegen3 branch February 12, 2023 00:10
@torikki-tou
Copy link

https://github.com/aiogram/butcher is 404 now, is it publicly available?

@JrooTJunior
Copy link
Member Author

It is hidden from public access, accessible only to the development team.

@torikki-tou
Copy link

sad to hear, any plans to opensource?

@JrooTJunior
Copy link
Member Author

Maybe in the future, but definitely not in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.x Issue or PR for stable 3.x version api Issues or new features of Bot API code style Changes in code style docs Something is missing in docs new feature Missing feature ported Ported feature or fix typing Issues related to the type hints and static typing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants