Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assertion error StreamParser class when using Python3.4.1-8 #131

Closed
riverrun opened this issue Jul 30, 2014 · 5 comments
Closed

Assertion error StreamParser class when using Python3.4.1-8 #131

riverrun opened this issue Jul 30, 2014 · 5 comments
Labels

Comments

@riverrun
Copy link

Hi,
I'm developing a url checker using aiohttp (https://github.com/riverrun/alinkcheck).
After upgrading Py3 to 3.4.1-8 (on Ubuntu 14.10), I was getting assertion errors complaining about the StreamParser (in parsers.py) not being a StreamReader.
In my case, I edited the parsers.py file and replaced line 71:
class StreamParser:
with
class StreamParser(asyncio.streams.StreamReader):
and with that I now get no errors.
I don't know if that will work for other people, but it seemed to work for me :)
If you need any more info, please let me know.

@paultag
Copy link
Member

paultag commented Aug 1, 2014

Ouch. Yeah. This just hit me pretty hard too.

It'd be great to get this fixed. The suggested fix works here.

Any chance we could get a hotfix?

@paultag
Copy link
Member

paultag commented Aug 1, 2014

paultag added a commit to paultag/moxie that referenced this issue Aug 1, 2014
  ... until aio-libs/aiohttp#131 is fixed.
fafhrd91 added a commit that referenced this issue Aug 2, 2014
@fafhrd91
Copy link
Member

fafhrd91 commented Aug 2, 2014

fixed

@fafhrd91 fafhrd91 closed this as completed Aug 2, 2014
@paultag
Copy link
Member

paultag commented Aug 4, 2014

Thanks, y'all! 💃

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants