Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement proxy support for ClientSession.ws_connect #1025

Closed
asvetlov opened this issue Jul 31, 2016 · 2 comments
Closed

Implement proxy support for ClientSession.ws_connect #1025

asvetlov opened this issue Jul 31, 2016 · 2 comments
Labels
good first issue Good for newcomers outdated

Comments

@asvetlov
Copy link
Member

No description provided.

@asvetlov asvetlov added the good first issue Good for newcomers label Aug 2, 2016
Taekyoon added a commit to Taekyoon/aiohttp that referenced this issue Aug 15, 2016
@Taekyoon
Implement proxy support for ClientSession.ws_connect
a52c4ea 
aio-libs#1025 Maybe.. Done..
I didn't check by Test mock....
But you said this would beeee OK... Hopefully ^^

This is my first commit.
@Taekyoon Taekyoon mentioned this issue Aug 15, 2016
Merged
1 task
asvetlov pushed a commit that referenced this issue Aug 25, 2016
@Taekyoon @asvetlov
Issues about #1025 and #1044 (#1088)
1a64fa7 
* Implement proxy support for ClientSession.ws_connect
#1025 Maybe.. Done..
I didn't check by Test mock....
But you said this would beeee OK... Hopefully ^^

This is my first commit.

* Client can not handle hostnames with 63 bytes when a port is given in the url #1044

I handled by reconstructing url string.
And I used function make_netlog in client_reqrep.py

* Client can not handle hostnames with 63 bytes when a port is given in the url #1044

I handled by reconstructing url string.
And I used function make_netlog in client_reqrep.py

* Client can not handle hostnames with 63 bytes when a port is given in the url #1044

#last Message##############################
I handled by reconstructing url string.
And I used function make_netlog in client_reqrep.py
#########################################

I added missing test functions.
It would verify by these methods

* Client can not handle hostnames with 63 bytes when a port is given in the url #1044

#last Message##############################
I handled by reconstructing url string.
And I used function make_netlog in client_reqrep.py
#########################################

I added missing test functions.
It would verify by these methods

* Fix the code format.
They all checked by flake8

* Fix the code format. @ client_reqrep.py
They all checked by flake8
@asvetlov
Copy link
Member Author

Fixed by #1088

@lock
Copy link

lock bot commented Oct 29, 2019

This thread has been automatically locked since there has not been
any recent activity after it was closed. Please open a new issue for
related bugs.

If you feel like there's important points made in this discussion,
please include those exceprts into that new issue.

@lock lock bot added the outdated label Oct 29, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 29, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
good first issue Good for newcomers outdated
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@asvetlov