Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nominate J. Nick Koston to aiohttp committers #7880

Closed
Dreamsorcerer opened this issue Nov 23, 2023 · 6 comments
Closed

Nominate J. Nick Koston to aiohttp committers #7880

Dreamsorcerer opened this issue Nov 23, 2023 · 6 comments
Labels

Comments

@Dreamsorcerer
Copy link
Member

Dreamsorcerer commented Nov 23, 2023

I'm nominating @bdraco to the aiohttp Core team.

There's plenty of examples in the previous weeks of good quality PRs, with all the tests we'd expect:
https://github.com/aio-libs/aiohttp/pulls?q=is%3Apr+author%3Abdraco+is%3Aclosed
There is a clear understanding of our development requirements.

@aio-libs/aiohttp-dev please vote here in the comments (or reaction).
The vote ends Wednesday, November 29.

@webknjaz
Copy link
Member

+1

@webknjaz webknjaz added the meta label Nov 23, 2023
@Dreamsorcerer
Copy link
Member Author

Great, @bdraco you should have access now.

@bdraco
Copy link
Member

bdraco commented Nov 29, 2023

Thank you!

On a side note, Home Assistant just shipped aiohttp 3.9.1 to the beta channel and so far everything has been going well.

@samuelcolvin
Copy link
Member

Great, thanks @bdraco for volunteering.

@webknjaz
Copy link
Member

webknjaz commented Dec 1, 2023

@bdraco if you want to be notified about changes to some files, that can be arranged through https://github.com/aio-libs/aiohttp/blob/master/.github/CODEOWNERS.
Also, FYI, we have a matrix space and rooms — #aio-libs-space:matrix.org and #aio-libs:matrix.org. That's where some people come to ask questions more interactively. Might be useful to have some presence there. Personally, these days I'm best reachable through matrix myself.

@bdraco
Copy link
Member

bdraco commented Dec 1, 2023

@bdraco if you want to be notified about changes to some files, that can be arranged through master/.github/CODEOWNERS.

Thanks. I've got notifications filtered via email pretty well so hopefully I won't miss anything that I'm concerned about.

Also, FYI, we have a matrix space and rooms — #aio-libs-space:matrix.org and #aio-libs:matrix.org. That's where some people come to ask questions more interactively. Might be useful to have some presence there. Personally, these days I'm best reachable through matrix myself.

I set up a matrix account and joined that room, however I'm usually much easier to reach on discord (same handle) if you need something urgently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants