Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query parameters remain encoded since yarl==1.6.0 #4981

Closed
deansg opened this issue Sep 29, 2020 · 2 comments
Closed

Query parameters remain encoded since yarl==1.6.0 #4981

deansg opened this issue Sep 29, 2020 · 2 comments
Labels

Comments

@deansg
Copy link

deansg commented Sep 29, 2020

I apologize in advance if this is not a bug, or alternatively, a bug which isn't in aiohttp. I'm reporting it here since I'm not familiar with the aiohttp code and I experienced this unexpected change in behaviour by using aiohttp.

🐞 Describe the bug

The query parameters from a Request object now appear in their url encoded form rather than the previously decoded form.

💡 To Reproduce

  1. Install aiohttp with yarl version 1.6.0 (came out in September 23)
  2. Write a simple http service with a controller
  3. Send a request with query parameters which include characters that get encoded in urls (such as spaces)
  4. Attempt to retrieve the query parameter objects and see that they are in an encoded form

💡 Expected behavior

The query parameters should be decoded, as before.

📋 Your version of the Python

$ python --version
...

3.7.9

📋 Your version of the aiohttp/yarl/multidict distributions

$ python -m pip show aiohttp
...
$ python -m pip show multidict
...
$ python -m pip show yarl
...

yarl==1.6.0
aiohttp==3.6.2
multidict==4.7.4

@deansg deansg added the bug label Sep 29, 2020
@TBBle
Copy link
Contributor

TBBle commented Sep 30, 2020

Duplicate of #4972.

@deansg
Copy link
Author

deansg commented Sep 30, 2020

Duplicate of #4972.

I've somehow missed the other one, sorry.

@deansg deansg closed this as completed Sep 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants