Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite WebSocketWriter to use StreamWriter #2837

Open
asvetlov opened this issue Mar 15, 2018 · 0 comments
Open

Rewrite WebSocketWriter to use StreamWriter #2837

asvetlov opened this issue Mar 15, 2018 · 0 comments

Comments

@asvetlov
Copy link
Member

Now websocket writer has custom flow control.
It's maybe not bad but overcomplicates things.
Since #2836 is done websocket writer uses coroutines everywhere, the transition should be smooth.

No Public API changes but limit=DEFAUTLT_LIMIT and MSG_SIZE will be dropped.
I see related micro-optimizations made by @fafhrd91 and @pfreixes but I believe the performance impact will be negligible.

Talking about performance using bytearray as websocket message structure and adding Cython optimization for parsing/building websocket header can get better speed boost.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants