From ca9f9158851cf6643dedb59ec0ed329b266f33d3 Mon Sep 17 00:00:00 2001 From: Pavel Filatov Date: Sat, 26 Oct 2019 12:07:06 +0300 Subject: [PATCH] Change typing of the secure argument on StreamResponse.set_cookie (#4238) --- CHANGES/4204.doc | 1 + aiohttp/web_response.py | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) create mode 100644 CHANGES/4204.doc diff --git a/CHANGES/4204.doc b/CHANGES/4204.doc new file mode 100644 index 00000000000..d27adb21e7a --- /dev/null +++ b/CHANGES/4204.doc @@ -0,0 +1 @@ +Change typing of the secure argument on StreamResponse.set_cookie from Optional[str] to a Optional[bool] diff --git a/aiohttp/web_response.py b/aiohttp/web_response.py index 2594cbf5a90..9a3075ff748 100644 --- a/aiohttp/web_response.py +++ b/aiohttp/web_response.py @@ -169,8 +169,8 @@ def set_cookie(self, name: str, value: str, *, domain: Optional[str]=None, max_age: Optional[Union[int, str]]=None, path: str='/', - secure: Optional[str]=None, - httponly: Optional[str]=None, + secure: Optional[bool]=None, + httponly: Optional[bool]=None, version: Optional[str]=None) -> None: """Set or update response cookie.