Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure all timers are cancelled when after staggered race finishes #136

Merged
merged 6 commits into from
Feb 7, 2025

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 7, 2025

There was a race where a TimerHandle could be left lingering

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (99edb20) to head (0fd33a0).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #136   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            5         5           
  Lines          231       231           
  Branches        47        47           
=========================================
  Hits           231       231           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bdraco bdraco merged commit f75891d into main Feb 7, 2025
23 checks passed
@bdraco bdraco deleted the fix_lingering_timers branch February 7, 2025 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant