Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use events to reduce footprint where possible #774

Closed
thehesiod opened this issue Feb 23, 2020 · 2 comments
Closed

Use events to reduce footprint where possible #774

thehesiod opened this issue Feb 23, 2020 · 2 comments
Labels
enhancement New feature or request Stale

Comments

@thehesiod
Copy link
Collaborator

@dazza-codes had the great insight to notice that the event creating-client-class.* would enable use to remove the AioClientCreator._create_client_class method be replacing the base_classes parameter with our AioBaseClient override.

We should go over the codebase wherever simplifications like this are possible.
@thehesiod thehesiod mentioned this issue Feb 23, 2020
Open
@thehesiod
Copy link
Collaborator Author

we probably should wait for #659 to land so we have async events

@thehesiod thehesiod added the enhancement New feature or request label Jun 12, 2021
@github-actions GitHub Actions
Copy link

This issue has been marked as stale because it has been inactive for more than 60 days. Please update this pull request or it will be automatically closed in 7 days.

@github-actions github-actions bot added the Stale label Aug 20, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Aug 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request Stale
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@thehesiod