Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #689; This is achieved by querying SUM_FORM instead of STUCT_FO… #690

Merged
merged 2 commits into from
Sep 11, 2017
Merged

Fixes #689; This is achieved by querying SUM_FORM instead of STUCT_FO… #690

merged 2 commits into from
Sep 11, 2017

Conversation

lekah
Copy link
Contributor

@lekah lekah commented Sep 8, 2017

…RM and explicitly checking beginning/end of line as well as spaces

@lekah
Fixes aiidateam#689; This is achieved by querying SUM_FORM instead of…
53d05cd 
… STUCT_FORM and explicitly checking beginning/end of line as well as spaces
@lekah lekah requested a review from nmounet September 8, 2017 09:13
nmounet
nmounet approved these changes Sep 11, 2017
View reviewed changes
Copy link

@nmounet nmounet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect

@nmounet nmounet merged commit 59e5f39 into aiidateam:develop Sep 11, 2017
@lekah lekah deleted the fix_689_icsd_importer_element_query branch September 13, 2017 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmounet nmounet nmounet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lekah @nmounet