Move the metadata.options namespace from Process to CalcJob
#3008
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_3006_move_metada_options_to_calcjob
branch
2 times, most recently
from
8227eb9 to
0b99a51
Compare
|
Coverage decreased (-0.04%) to 72.987% when pulling 0b99a515d5d320dd0e171ba3feca585219bdb334 on sphuber:fix_3006_move_metada_options_to_calcjob into ababf1c on aiidateam:develop. |
The `metadata.options` namespace only applies to the `CalcJob` process class, yet it is defined on the `Process` base class. This means that, process builders for `WorkChains`, for example, will also display this as an available namespace, even though it shouldn't. It may seem harmless, but having an apparently namespace available that does not actually do anything can be confusing.
sphuber
force-pushed
the
fix_3006_move_metada_options_to_calcjob
branch
from
0b99a51 to
e15cb45
Compare
giovannipizzi
approved these changes
Jun 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3006
The
metadata.optionsnamespace only applies to theCalcJobprocessclass, yet it is defined on the
Processbase class. This means that,process builders for
WorkChains, for example, will also display this asan available namespace, even though it shouldn't. It may seem harmless,
but having an apparently namespace available that does not actually do
anything can be confusing.