Ensure that stacktrace is included in transport task exceptions #2986
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a transport task of a calculation job excepts, the expontential back off retry wrapper calls the logger of the process node with the exception. This will trigger the `DbLogHandler` such that the log message is entered into the database with a link to the process node. However, only the message was included and not the stack trace which made it difficult to determine the cause from `verdi process report`. To fix this, in the `Log.objects.create_from_record` we attempt to format a traceback from the `exc_info` if it is included in the record which will be the case for an exception log. This commit also fixes a bug in the `ProcessLauncher._continue` method that was calling the `create_future` method of the communicator, which has long been removed. Instead a normal future should just be created.
ltalirz
suggested changes
Jun 9, 2019
aiida/engine/utils.py
Outdated
| @@ -180,13 +180,15 @@ def exponential_backoff_retry(fct, initial_interval=10.0, max_attempts=5, logger | |||
| if ignore_exceptions is not None and isinstance(exception, ignore_exceptions): | |||
| raise | |||
|
|
|||
| count = iteration + 1 | |||
| core_name = coro.__name__ | |||
| @@ -180,13 +180,15 @@ def exponential_backoff_retry(fct, initial_interval=10.0, max_attempts=5, logger | |||
| if ignore_exceptions is not None and isinstance(exception, ignore_exceptions): | |||
There was a problem hiding this comment.
ignore_exceptions seems to be missing a docstring. Can you add one?
It's not self-evident that "ignoring exceptions" means re-rasing them
ltalirz
approved these changes
Jun 9, 2019
|
thanks for the review @ltalirz |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2898 and fixes #2984
When a transport task of a calculation job excepts, the exponential
back off retry wrapper calls the logger of the process node with the
exception. This will trigger the
DbLogHandlersuch that the logmessage is entered into the database with a link to the process node.
However, only the message was included and not the stack trace which
made it difficult to determine the cause from
verdi process report.To fix this, in the
Log.objects.create_from_recordwe attempt toformat a traceback from the
exc_infoif it is included in the recordwhich will be the case for an exception log.
This commit also fixes a bug in the
ProcessLauncher._continuemethodthat was calling the
create_futuremethod of the communicator, whichhas long been removed. Instead a normal future should just be created.