Added posibility to forward arguments to PGTest when using the fixture. #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Coverage increased (+0.005%) to 72.685% when pulling a3a27e9df73cbcaece7f3a13ea36e651f89f5714 on espenfl:pgtest_argument_forwarding into b8eaffc on aiidateam:develop. |
espenfl
force-pushed
the
pgtest_argument_forwarding
branch
2 times, most recently
from
8fb0f13 to
0bf518f
Compare
espenfl
force-pushed
the
pgtest_argument_forwarding
branch
from
0bf518f to
34ba72e
Compare
sphuber
approved these changes
Jun 6, 2019
This was referenced Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
pgtest, trough the fixtures we need the possibility for the user to request a specificpg_ctlversion in case several versions are installed (sometimes in production systems, this is unavoidable). This should be rather general and could forward any present and upcoming valid parameters by issuingfixture_manager(pgtest={'some_arg': 'some_value'}). Of particular interest isfixture_manager(pgtest={'pg_ctl': '/somepath/pg_ctl'})