Ensure mtime update is triggered for Django
#2935
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `ModelWrapper` utility class ensures that a database model instance is automatically saved if a model field is updated and the instance is already stored. This prevents the implementation from having to call `save` manually everytime a field is updated. The Django implementation uses the `update_fields` keyword of the `save` method, to update only the field affected. However, this circumvents the `auto_now` of the `mtime` field. This bug is currently not visible, because in the model wrapper currently also always updates the node version after a model field is updated of a stored instance. This, however, uses a normal `save` and so does properly update the `mtime`. Once this updating of the node version would have been removed, this bug will be revealed.
2 similar comments
giovannipizzi
approved these changes
May 28, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2934
The
ModelWrapperutility class ensures that a database model instanceis automatically saved if a model field is updated and the instance is
already stored. This prevents the implementation from having to call
savemanually every time a field is updated. The Django implementationuses the
update_fieldskeyword of thesavemethod, to update onlythe field affected. However, this circumvents the
auto_nowof themtimefield. This bug is currently not visible, because in the modelwrapper currently also always updates the node version after a model
field is updated of a stored instance. This, however, uses a normal
saveand so does properly update themtime. Once this updating ofthe node version would have been removed, this bug will be revealed.