Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Require store_provenance=True in submit or raise #2828

Merged
merged 1 commit into from
May 2, 2019
Merged

Require store_provenance=True in submit or raise #2828

merged 1 commit into from
May 2, 2019

Conversation

sphuber
Copy link
Contributor

@sphuber sphuber commented May 2, 2019

Fixes #2826

The current design of submitting processes, requires them to be stored
in the database as the state is stored as a checkpoint on the node. This
means that allowing store_provenance=False is non-sensical and will
lead to unexpected and cryptic errors. Instead we check for this value
and raise when set to False in combination with submit.

@sphuber
Require store_provenance=True in submit or raise
b8ce278 
The current design of submitting processes, requires them to be stored
in the database as the state is stored as a checkpoint on the node. This
means that allowing `store_provenance=False` is non-sensical and will
lead to unexpected and cryptic errors. Instead we check for this value
and raise when set to False in combination with `submit`.
@sphuber sphuber requested a review from giovannipizzi May 2, 2019 15:05
@sphuber sphuber merged commit 26ce603 into aiidateam:develop May 2, 2019
@sphuber sphuber deleted the fix_2826_submit_store_provenance_false_raises branch May 2, 2019 16:01
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 71.702% when pulling b8ce278 on sphuber:fix_2826_submit_store_provenance_false_raises into c7fd2d6 on aiidateam:develop.

2 similar comments
@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 71.702% when pulling b8ce278 on sphuber:fix_2826_submit_store_provenance_false_raises into c7fd2d6 on aiidateam:develop.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.04%) to 71.702% when pulling b8ce278 on sphuber:fix_2826_submit_store_provenance_false_raises into c7fd2d6 on aiidateam:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@giovannipizzi giovannipizzi giovannipizzi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Check that store_provenance=True in submit
3 participants
@sphuber @coveralls @giovannipizzi