Remove default dynamicity of WorkChain port namespaces
#2825
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_2822_workchains_non_dynamic
branch
from
522ff33 to
f136840
Compare
This was already removed recently for the `Process` base class but was overridden by the `WorkChain` class. Given that having the input and output port namespace can lead to unexpected behavior for novice users, it was decided to have them non-dynamic by default.
sphuber
force-pushed
the
fix_2822_workchains_non_dynamic
branch
from
f136840 to
c7ee88f
Compare
giovannipizzi
approved these changes
May 2, 2019
1 similar comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2822
This was already removed recently for the
Processbase class but wasoverridden by the
WorkChainclass. Given that having the input andoutput port namespace can lead to unexpected behavior for novice users,
it was decided to have them non-dynamic by default.