Added separate user projection in query help for rest api #2793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
szoupanos
previously approved these changes
Apr 25, 2019
aiida/restapi/translator/node.py
Outdated
| @@ -268,7 +269,7 @@ def _get_content(self): | |||
| return {} | |||
|
|
|||
| # otherwise ... | |||
| node = self.qbobj.first()[0] | |||
| node = self.qbobj.all()[0][1] | |||
There was a problem hiding this comment.
We should see with Leonid why this is not possible anymore.
If we don't find a solution, a ticket should be opened.
|
This should be merged after it is tested with the django_jsonb branch where the hybrid properties are removed. I will need help from @sphuber to rebase the django_jsonb branch since after his last PRs I have conflicts that are not obvious to resolve. Then we can test this PR with the rebased django_jsonb and merge it to develop. |
|
I have tested this with the |
Automatically projection user email for nodes relied on hybrid properties in SqlAlchemy, which have been removed. The alternative is to explicitly join on the User entity and project separately.
sphuber
approved these changes
May 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #2764