Hide verdi daemon start-circus from auto-completion and help
#2755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This command should not be called directly by users but will rather be invoked by `verdi daemon start`. This is accomplished by marking the command as `hidden=True` which was implemented in `click==7.0`. However, the attribute was being ignored by the `click-completion` package, which was fixed in `click-completion==0.5.1` which is now added as dependency.
ltalirz
approved these changes
Apr 14, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2537
This command should not be called directly by users but will rather be
invoked by
verdi daemon start. This is accomplished by marking thecommand as
hidden=Truewhich was implemented inclick==7.0. However,the attribute was being ignored by the
click-completionpackage, whichwas fixed in
click-completion==0.5.1which is now added as dependency.