Use binary mode for local copy list in upload_calculation
#2748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sphuber
force-pushed
the
fix_2725_use_binary_handles_upload_calculation
branch
from
baa3b88 to
3fb79d6
Compare
sphuber
changed the title
upload_calculationupload_calculation
|
@giovannipizzi although I think we should sit down sometime to really think how we should handle file operations in the various places that we do, I think we should merge this for now since we are planning on releasing |
giovannipizzi
approved these changes
May 14, 2019
sphuber
force-pushed
the
fix_2725_use_binary_handles_upload_calculation
branch
from
3fb79d6 to
fc9f28d
Compare
The file content of the files in the node repository is not necessarily encoded but could be binary, so the best thing is to not guess the encoding but transfer the raw bytes.
sphuber
force-pushed
the
fix_2725_use_binary_handles_upload_calculation
branch
from
fc9f28d to
17403eb
Compare
unkcpz
pushed a commit
to unkcpz/aiida-core
that referenced
this pull request
May 20, 2019
…m#2748) The file content of the files in the node repository is not necessarily encoded but could be binary, so the best thing is to not guess the encoding but transfer the raw bytes.
unkcpz
pushed a commit
to unkcpz/aiida-core
that referenced
this pull request
May 20, 2019
…m#2748) The file content of the files in the node repository is not necessarily encoded but could be binary, so the best thing is to not guess the encoding but transfer the raw bytes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2725
The file content of the files in the node repository is not necessarily
encoded but could be binary, so the best thing is to not guess the
encoding but transfer the raw bytes.