fix process control in direct scheduler #2721
Conversation
The direct scheduler was using `ps` for checking whether a command is
running. However, `ps` does not show processes without a controlling
terminal - for this you need to add the -x option:
-x When displaying processes matched by other options, include pro-
cesses which do not have a controlling terminal. This is the
opposite of the -X option. If both -X and -x are specified in
the same command, then ps will use the one which was specified
last.
|
What I haven't done here is add a test that would catch a regression. Is there also an actual test of a scheduler? |
|
Why didn't this problem affect me on theossrv5? Is this behavior specific to MacOS or should it also affect Linux? |
|
@sphuber I try to answer (with a few more questions) in the issue |
|
@sphuber @giovannipizzi can this be merged? |
|
Could you please add a little bit more information to the comment you added at the |
|
Done! |
fix #2649
The direct scheduler was using
psfor checking whether a process isrunning. However,
psdoes not show processes without a controllingterminal - for this you need to add the -x option:
-x When displaying processes matched by other options, include pro-
cesses which do not have a controlling terminal. This is the
opposite of the -X option. If both -X and -x are specified in
the same command, then ps will use the one which was specified
last.