-
Notifications
You must be signed in to change notification settings - Fork 191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add verdi status command #2487
add verdi status command #2487
Conversation
Shows * profile status * daemon status To add: * rmq status * postgres status * file repo status
+ status for postgres + status for rabbitmq + status for file repository todo: + document this + get rid of load_dbenv (needed for rmq at the moment) + file repo always created automatically. do we want this?
Cool! Do you plan to fix all the tick boxes before merging? In this case, can you add [WIP] to the title? |
@giovannipizzi Done. Can you perhaps comment on the last todo item? |
I suggest to only check existence for now, and mention this in the issue about improving the file repository - I don't think it makes sense to spend toouch effort there now, and additional checks might not be particularly useful at this stage. |
+ remove mandatory dependency on aiida.common.serialize since it requires the dbenv
…re into issue_2409_verdi_status
…re into issue_2409_verdi_status
Added test, which passes on my machine while still showing the following error:
@sphuber Do you have an idea what this means? |
@ltalirz no unfortunately, I have never seen that exception before |
so that you can paste them into forums/on github without losing the meaning
@ltalirz would this be ready for review? |
Happy for your feedback if you find the time. Another problem is that, even with |
Probably just because it is writing to |
* capture stderr as well * stop communicator after creating it
@sphuber both issues should be fixed now. |
…re into issue_2409_verdi_status
Just did and got the following:
Clearly there is a problem with the call to postgres, but that should not be the case. Will see the reason why. Then regarding layout, it would be nice if we can line the values out on the same column. Now it seems that there is a space in front of the repository path |
Problem for postgres failing is because of the line
Even though it should be able to connect just fine. |
Thanks, yes I thought that |
@ltalirz just a quick FYI: each time you push a commit to an open PR will trigger a new build, blocking all other builds for the |
* use parameters specified in profile to check connectivity * fix aiidateam#2519
closing this until tests pass |
* move back to regular dict (I thought frozendict was used elsewhere but apparently it isn't) * make Postgres.from_profile more robust to be able to handle test configurations that are missing data
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested it locally on Ubuntu 18.04 and it seems to be working. This is the scenario where all services are up. Only few minor comments remain
Thanks a lot @ltalirz |
verdi status
command #2409Adds a
verdi status
command that shows the status of the different AiiDa services.I'm sure it can still be improved and made more robust, but it's a start.
To do:
load_dbenv
. Currently, the command loads the dbenv becauseget_communicator
requires it. It is not clear why this is necessary, perhaps @sphuber can clarify this (and possibly provide a workaround). I wonder - shouldaiida.work.rmq
actually be moved toaiida.manage.external
?Latest version
$ verdi status ✓ profile: On profile test_qb ✓ repository: /Users/leopold/Personal/Postdoc-MARVEL/aiida_folders/aiida_rmq/.aiida/repository/test_qb ✓ postgres: Connected to postgres@localhost:5432 ✓ rabbitmq: Connected to amqp://127.0.0.1?heartbeat=600 ✗ daemon: The daemon is not running